[Fix-5540][JSON Split] Fix some new tables and fields are missing in the sql upgrade script#5611
Merged
wen-hemin merged 20 commits intoapache:devfrom Jun 15, 2021
echohlne:sql_scheme_upgrade
Merged
[Fix-5540][JSON Split] Fix some new tables and fields are missing in the sql upgrade script#5611wen-hemin merged 20 commits intoapache:devfrom echohlne:sql_scheme_upgrade
wen-hemin merged 20 commits intoapache:devfrom
echohlne:sql_scheme_upgrade
Conversation
echohlne
changed the title
chengshiwen
changed the title
chengshiwen
changed the title
Member
|
@JinyLeeChina please take a look.Thx |
CalvinKirs
added
first time contributor
Codecov Report
@@ Coverage Diff @@
## dev #5611 +/- ##
============================================
+ Coverage 45.16% 45.35% +0.19%
- Complexity 3657 3675 +18
============================================
Files 607 607
Lines 24758 24780 +22
Branches 2798 2801 +3
============================================
+ Hits 11181 11240 +59
+ Misses 12510 12468 -42
- Partials 1067 1072 +5
Continue to review full report at Codecov.
|
brave-lee
reviewed
Jun 10, 2021
| DROP PROCEDURE uc_dolphin_T_t_ds_process_definition_A_add_code; | ||
|
|
||
| -- uc_dolphin_T_t_ds_process_definition_A_add_project_code | ||
| drop PROCEDURE if EXISTS uc_dolphin_T_t_ds_process_definition_A_add_project_code; |
Contributor
There was a problem hiding this comment.
I think there should be remove project_id from t_ds_process_definition
| THEN | ||
| ALTER TABLE t_ds_process_definition ADD `code` bigint(20) NOT NULL COMMENT 'encoding'; | ||
| END IF; | ||
| END; |
Contributor
There was a problem hiding this comment.
Please add warning_group_id to t_ds_process_definition
Contributor
Author
There was a problem hiding this comment.
@JinyLeeChina
warning_group_id has been added before.| DROP PROCEDURE uc_dolphin_T_t_ds_project_instance_A_add_code; | ||
|
|
||
| -- uc_dolphin_T_t_ds_process_definition_A_add_code | ||
| drop PROCEDURE if EXISTS uc_dolphin_T_t_ds_process_definition_A_add_code; |
Contributor
There was a problem hiding this comment.
Please update UNIQUE KEY of t_ds_process_definition
Contributor
Author
There was a problem hiding this comment.
thanks @JinyLeeChina , solved it.
Contributor
|
Thanks for your contribution, pls fix review comment |
wen-hemin
requested changes
Jun 10, 2021
Contributor
wen-hemin
left a comment
wen-hemin
left a comment
There was a problem hiding this comment.
Thank you for your contribution, please check
Contributor
Author
|
@JinyLeeChina @wen-hemin, thanks for your review, I have update the code, please review again, thanks!🤪 |
|
Hi:
|
Contributor
|
+1 |
|
Hi:
|
1 similar comment
|
Hi:
|
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
The PRs associated with issue-4417 introduced a large number of database schema changes, but these new features were not represented in the corresponding SQL files in the Dev branch, resulting in some runtime exceptions in the dev code environment,
Fix #5540, Fix ##5610
reproduce step:
org.apache.dolphinscheduler.dao.upgrade.shell.CreateDolphinSchedulerBrief change log
According to the
sql\dolphinscheduler_mysql.sqlandsql\dolphinscheduler_postgre.sql, I tried to add the newly added tables and fields in the upgrade script.Verify this pull request
what's more , The database schema changes very frequently, and I think the related unit tests may not cover all aspects. When I have time, may be I can explore whether there is a better way to detect the SQL problem, is anyone has good ideas ?