[Improvement] Fix a potential problem when editing an existing mysql data source#5670
Merged
CalvinKirs merged 1 commit intoapache:devfrom Jun 21, 2021
echohlne:edit_existsed_datasource_error_null
Merged
[Improvement] Fix a potential problem when editing an existing mysql data source#5670CalvinKirs merged 1 commit intoapache:devfrom echohlne:edit_existsed_datasource_error_null
CalvinKirs merged 1 commit intoapache:devfrom
echohlne:edit_existsed_datasource_error_null
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #5670 +/- ##
=========================================
Coverage 45.31% 45.32%
+ Complexity 3673 3672 -1
=========================================
Files 607 607
Lines 24794 24794
Branches 2803 2803
=========================================
+ Hits 11235 11237 +2
+ Misses 12489 12486 -3
- Partials 1070 1071 +1
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Fix a potential problem that editing an existing mysql data source may cause the backend to return null data.
reproduce step:
Request URL: http://localhost:8888/dolphinscheduler/datasources/update
response {"code":null,"msg":null,"data":null}
Brief change log
fix a special case in edit an existing datasource.
The result instance does not have a certain code and msg value, which results in the content returned to the front end shows as
null. In this case, just return isConnection directly.Verify this pull request
Using Existed UTs.
Alse munutal test works well