Skip to content

[Improvement-5405][Docker/K8s] Adapt to registry SPI#5681

Merged
CalvinKirs merged 1 commit intoapache:devfrom
chengshiwen:improve-adapt-registry-spi
Jun 23, 2021
Merged

[Improvement-5405][Docker/K8s] Adapt to registry SPI#5681
CalvinKirs merged 1 commit intoapache:devfrom
chengshiwen:improve-adapt-registry-spi

Conversation

@chengshiwen
Copy link
Member

Purpose of the pull request

[Improvement-5405][Docker/K8s] Adapt to registry SPI

This closes #5405

Brief change log

  • Adapt to registry SPI in docker and k8s

Verify this pull request

This change added tests and can be verified as follows:

  • Manually verified the change by testing locally.

@codecov-commenter
Copy link

Codecov Report

Merging #5681 (c020031) into dev (d64e3cb) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #5681      +/-   ##
============================================
- Coverage     45.31%   45.31%   -0.01%     
+ Complexity     3678     3677       -1     
============================================
  Files           607      607              
  Lines         24797    24797              
  Branches       2803     2803              
============================================
- Hits          11237    11236       -1     
- Misses        12489    12490       +1     
  Partials       1071     1071              
Impacted Files Coverage Δ
...lphinscheduler/rpc/common/AbstractRpcCallBack.java 0.00% <0.00%> (-100.00%) ⬇️
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 83.05% <0.00%> (+1.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d64e3cb...c020031. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docker & K8s Improvement Plan Round 2

3 participants