Skip to content

[Bug-Fix 5692] Fix schedule time for completion.#5695

Closed
wordhardqi wants to merge 9 commits intoapache:devfrom
wordhardqi:patch-2
Closed

[Bug-Fix 5692] Fix schedule time for completion.#5695
wordhardqi wants to merge 9 commits intoapache:devfrom
wordhardqi:patch-2

Conversation

@wordhardqi
Copy link
Contributor

Fix #5692

@CalvinKirs
Copy link
Member

hi, thanks for your contribution, can you resolve the CI error?

}
}

// set the schedule time
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I don't think the spark parameter can be modified here, which will affect other components, please check

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2021

Codecov Report

Merging #5695 (15be00e) into dev (b31ba7e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #5695      +/-   ##
============================================
- Coverage     45.36%   45.36%   -0.01%     
- Complexity     3688     3690       +2     
============================================
  Files           607      607              
  Lines         24855    24871      +16     
  Branches       2825     2828       +3     
============================================
+ Hits          11275    11282       +7     
- Misses        12498    12507       +9     
  Partials       1082     1082              
Impacted Files Coverage Δ
...ache/dolphinscheduler/server/utils/ParamUtils.java 94.44% <100.00%> (+1.11%) ⬆️
...lphinscheduler/dao/entity/AlertPluginInstance.java 80.00% <0.00%> (-16.56%) ⬇️
...i/service/impl/AlertPluginInstanceServiceImpl.java 67.77% <0.00%> (-1.04%) ⬇️
...ache/dolphinscheduler/dao/entity/TaskInstance.java 65.18% <0.00%> (-0.49%) ⬇️
...hinscheduler/api/controller/ProjectController.java 76.00% <0.00%> (ø)
...inscheduler/spi/plugin/DolphinPluginDiscovery.java 0.00% <0.00%> (ø)
...nscheduler/api/controller/SchedulerController.java 4.76% <0.00%> (ø)
...uler/api/controller/ProcessInstanceController.java 4.54% <0.00%> (ø)
...uler/api/controller/WorkFlowLineageController.java 63.15% <0.00%> (ø)
...heduler/server/master/runner/MasterExecThread.java 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b31ba7e...15be00e. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@caishunfeng
Copy link
Contributor

Hi @wordhardqi Please check the latest code again. This pr will be closed because no update for a long time, you can reopen it if need.

@caishunfeng caishunfeng closed this Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][Spark] When completing data, the time template replacement is not correct.

5 participants