Skip to content

Revert "Fix the bug Edit User Info will always shows failed."#5698

Closed
chengshiwen wants to merge 1 commit intodevfrom
revert-5627-edit_user_failed
Closed

Revert "Fix the bug Edit User Info will always shows failed."#5698
chengshiwen wants to merge 1 commit intodevfrom
revert-5627-edit_user_failed

Conversation

@chengshiwen
Copy link
Member

Reverts #5627

New bug introduced and solution #5627 is unreasonable

@codecov-commenter
Copy link

Codecov Report

Merging #5698 (bed5605) into dev (b31ba7e) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #5698      +/-   ##
============================================
- Coverage     45.36%   45.35%   -0.02%     
+ Complexity     3688     3687       -1     
============================================
  Files           607      607              
  Lines         24855    24855              
  Branches       2825     2825              
============================================
- Hits          11275    11272       -3     
- Misses        12498    12499       +1     
- Partials       1082     1084       +2     
Impacted Files Coverage Δ
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...olphinscheduler/plugin/alert/email/MailSender.java 72.91% <0.00%> (-1.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b31ba7e...bed5605. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@echohlne
Copy link
Contributor

echohlne commented Jun 26, 2021

@chengshiwen Sorry for the trouble bring to you, my modification is based on 2 known issues:

  1. When we open the user information page, the enable/disable status of current user would always shows empty

image

----so I add this:

this.state = this.item.state
  1. If the user has not configured a tenant yet, if he just want to modify his personal information, It would always occurs an error, the main reason is shown as the note:
    image

    // If the user has not configured a tenant yet, this.item.tenantId would be 0, the if check returns false
    // so I try to add a new check like this: if (this.item.tenantId || this.item.tenantId === 0) 
    if (this.item.tenantId) {
    	this.tenantId = this.item.tenantId
    }

It's my fault that I did not explain clearly the reason for my modification in pr #5627
when I submit the pr, I've verified all the scenarios I know. I'm not sure what's the new bug you said ? If a bug is introduced, I am very sorry, hoping for your reply. 😛

@chengshiwen chengshiwen deleted the revert-5627-edit_user_failed branch June 26, 2021 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants