Skip to content

[Improvement-5858][Docker] Improve docker image support multi-arch like arm64 in docker-compose#5859

Closed
chengshiwen wants to merge 1 commit intoapache:devfrom
chengshiwen:improve-docker-multi-arch
Closed

[Improvement-5858][Docker] Improve docker image support multi-arch like arm64 in docker-compose#5859
chengshiwen wants to merge 1 commit intoapache:devfrom
chengshiwen:improve-docker-multi-arch

Conversation

@chengshiwen
Copy link
Member

Purpose of the pull request

[Improvement-5858][Docker] Improve docker image support multi-arch like arm64 in docker-compose

This closes #5858

Brief change log

  • Improve docker image support multi-arch like arm64
  • Support docker buildx
  • Support arm64 in docker-compose

Verify this pull request

This change added tests and can be verified as follows:

  • Manually verified the change by testing locally.

@codecov-commenter
Copy link

Codecov Report

Merging #5859 (f401404) into dev (5e343d3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev    #5859   +/-   ##
=========================================
  Coverage     45.03%   45.03%           
  Complexity     3656     3656           
=========================================
  Files           606      606           
  Lines         24876    24876           
  Branches       2835     2835           
=========================================
  Hits          11204    11204           
  Misses        12600    12600           
  Partials       1072     1072           
Impacted Files Coverage Δ
...dolphinscheduler/remote/future/ResponseFuture.java 81.35% <0.00%> (-1.70%) ⬇️
...er/master/dispatch/host/assign/RandomSelector.java 83.33% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e343d3...f401404. Read the comment docs.

@xied75
Copy link

xied75 commented Jul 20, 2021

👍 Just to clarify, all those tests (GitHub Actions) still only targeted AMD64, we haven't actually proved that the code base do run on aarch64 without any glitch. Seems Azure support of aarch64 is yet to come, but last I checked Travis-CI do have ability to run test on arm64.

@chengshiwen chengshiwen force-pushed the improve-docker-multi-arch branch from f401404 to 5213eb8 Compare July 27, 2021 11:11
@shink
Copy link
Member

shink commented Jul 27, 2021

The reason why workflows failed is the connection of maven timed out. I think you can rerun those failed workflows.

Failed to read artifact descriptor for org.apache.maven.shared:maven-common-artifact-filters:jar:3.0.1: Could not transfer artifact org.apache.maven.shared:maven-common-artifact-filters:pom:3.0.1 from/to central (https://repo.maven.apache.org/maven2): transfer failed for https://repo.maven.apache.org/maven2/org/apache/maven/shared/maven-common-artifact-filters/3.0.1/maven-common-artifact-filters-3.0.1.pom: Connection timed out (Read failed)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

github-actions bot commented Jan 5, 2022

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Jan 5, 2022
@github-actions
Copy link

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.

@github-actions github-actions bot closed this Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement][Docker] Docker image should support multi-arch like arm64 in docker-compose

4 participants