Skip to content

[1.3.7-prepare#5256][Improvement][common]Task status error#5862

Merged
CalvinKirs merged 2 commits intoapache:1.3.7-preparefrom
CalvinKirs:1.3.7-prepare#5256
Jul 22, 2021
Merged

[1.3.7-prepare#5256][Improvement][common]Task status error#5862
CalvinKirs merged 2 commits intoapache:1.3.7-preparefrom
CalvinKirs:1.3.7-prepare#5256

Conversation

@CalvinKirs
Copy link
Member

issue #5026
pr #5256

Copy link
Contributor

@Technoboy- Technoboy- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

logger.debug("yarn application url:{}, applicationId:{}", appUrl, applicationId);
}
return String.format(appUrl, applicationId);
String activeResourceManagerPort = String.valueOf(PropertyUtils.getInt(Constants.HADOOP_RESOURCE_MANAGER_HTTPADDRESS_PORT, 8088));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we place here with PropertyUtils.getString?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your remind. done

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants