Skip to content

[1.3.7-prepare#5421] Change the status box text (#5421)#5868

Merged
CalvinKirs merged 2 commits intoapache:1.3.7-preparefrom
ruanwenjun:dev_wenjun_1.3.7-prepare_UI
Jul 27, 2021
Merged

[1.3.7-prepare#5421] Change the status box text (#5421)#5868
CalvinKirs merged 2 commits intoapache:1.3.7-preparefrom
ruanwenjun:dev_wenjun_1.3.7-prepare_UI

Conversation

@ruanwenjun
Copy link
Member

pr #5421

@ruanwenjun ruanwenjun changed the title [Improvement] Change the status box text (#5421) [1.3.7-prepare#5421] Change the status box text (#5421) Jul 20, 2021
'Create Resource': '创建资源',
'User Center': '用户中心',
'Please enter method': '请输入方法',
AllStatus: '全部状态',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing single quote?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review, it seems the single quote is not required. Both the two kinds of writing exist in the project.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about keeping the same with others?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_1.3.7-prepare_UI branch from d5a400e to b7e493e Compare July 25, 2021 03:12
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@Technoboy- Technoboy- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CalvinKirs CalvinKirs merged commit 9015592 into apache:1.3.7-prepare Jul 27, 2021
@ruanwenjun ruanwenjun deleted the dev_wenjun_1.3.7-prepare_UI branch May 23, 2022 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants