[Improvement] Fix unchecked type conversions

[lyxell]

Fix compiler warnings about unchecked type conversions.

Brief change log

• Fix compiler warnings about unchecked type conversions in DAG.java, ResourceProcessDefinitionUtilsTest.java, NettyExecutorManager.java and MasterExecThreadTest.java

Verify this pull request

No functional changes, test coverage is not affected.

---

This patch was generated automatically using Logifix.

[ruanwenjun]

LGTM

And I have a question, when should we use Collections.emptySet in program, becase this method return an immutable set, If the upper layer want to add elements, they need to create a new HashSet.

[lyxell]

LGTM

Great!

And I have a question, when should we use Collections.emptySet in program, becase this method return an immutable set, If the upper layer want to add elements, they need to create a new HashSet.

I think Collections.emptySet is a good default. If the user needs a modifiable set they can always make a copy.

[ruanwenjun]

@lyxell OK, I just feel it's troublesome to do a copy whenever get a set or list. Maybe it's common in functional scenarios.

And you need to fix the code style.

[lyxell]

@ruanwenjun Sure, this pull request did not introduce that checkstyle error, but I can fix it anyway.

[codecov-commenter]

Codecov Report

Merging #6003 (db6db88) into dev (4b892f7) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##                dev    #6003      +/-   ##
============================================
- Coverage     46.75%   46.75%   -0.01%     
+ Complexity     3744     3743       -1     
============================================
  Files           604      604              
  Lines         24829    24829              
  Branches       2836     2836              
============================================
- Hits          11610    11608       -2     
- Misses        12077    12078       +1     
- Partials       1142     1143       +1     

Impacted Files	Coverage Δ
...master/dispatch/executor/NettyExecutorManager.java	0.00% <0.00%> (ø)
.../org/apache/dolphinscheduler/common/graph/DAG.java	96.03% <100.00%> (ø)
...er/master/dispatch/host/assign/RandomSelector.java	77.77% <0.00%> (-5.56%)	⬇️
...heduler/server/master/runner/MasterExecThread.java	16.08% <0.00%> (-0.19%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b892f7...db6db88. Read the comment docs.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

50.0% Coverage
0.0% Duplication