Skip to content

[Bug] [UI] Fix Delete project error#6174

Merged
brave-lee merged 2 commits intoapache:devfrom
Tandoy:issue-6170
Sep 25, 2021
Merged

[Bug] [UI] Fix Delete project error#6174
brave-lee merged 2 commits intoapache:devfrom
Tandoy:issue-6170

Conversation

@Tandoy
Copy link
Copy Markdown
Contributor

@Tandoy Tandoy commented Sep 11, 2021

·fix delete project error
·This closes #6170

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@Tandoy Tandoy changed the title ·fix delete project error [Bug] [UI] Delete project error Sep 11, 2021
@Tandoy Tandoy changed the title [Bug] [UI] Delete project error [Bug] [UI] Fix Delete project error Sep 16, 2021
@RichardStark
Copy link
Copy Markdown
Contributor

+1 meet the same issue and fixed use this method

@Tandoy
Copy link
Copy Markdown
Contributor Author

Tandoy commented Sep 24, 2021

@ruanwenjun
Can you review this pr, if you have time. Thanks~

@brave-lee
Copy link
Copy Markdown
Contributor

Please fix ut error

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #6174 (ebd471f) into dev (dee191f) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #6174      +/-   ##
============================================
+ Coverage     38.90%   38.98%   +0.07%     
- Complexity     3220     3226       +6     
============================================
  Files           637      637              
  Lines         25436    25436              
  Branches       2767     2767              
============================================
+ Hits           9897     9915      +18     
+ Misses        14633    14615      -18     
  Partials        906      906              
Impacted Files Coverage Δ
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...inscheduler/common/thread/ThreadPoolExecutors.java 21.15% <0.00%> (+1.92%) ⬆️
...rver/master/processor/queue/TaskResponseEvent.java 100.00% <0.00%> (+6.45%) ⬆️
...er/master/processor/queue/TaskResponseService.java 55.29% <0.00%> (+15.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dee191f...ebd471f. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Tandoy
Copy link
Copy Markdown
Contributor Author

Tandoy commented Sep 25, 2021

Please fix ut error

@JinyLeeChina The UI error has been resolved, please review.

Copy link
Copy Markdown
Contributor

@brave-lee brave-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@brave-lee brave-lee merged commit b71f6ae into apache:dev Sep 25, 2021
yc322 pushed a commit to yc322/dolphinscheduler that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [UI] Delete project error

4 participants