Skip to content

fixBug('#6172') [UI]Dag node name value judgment error#6175

Merged
lenboo merged 2 commits intoapache:devfrom
break60:dev
Sep 16, 2021
Merged

fixBug('#6172') [UI]Dag node name value judgment error#6175
lenboo merged 2 commits intoapache:devfrom
break60:dev

Conversation

@break60
Copy link
Copy Markdown
Contributor

@break60 break60 commented Sep 11, 2021

issues #6172

Technoboy-
Technoboy- previously approved these changes Sep 11, 2021
CalvinKirs
CalvinKirs previously approved these changes Sep 13, 2021
Copy link
Copy Markdown
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CalvinKirs
Copy link
Copy Markdown
Member

please resolve conflicting files.thx

@break60
Copy link
Copy Markdown
Contributor Author

break60 commented Sep 15, 2021

please resolve conflicting files.thx

ut seems to be caused by the ut test, and has nothing to do with the front-end code

@CalvinKirs
Copy link
Copy Markdown
Member

please resolve conflicting files.thx

ut seems to be caused by the ut test, and has nothing to do with the front-end code

can you update the code?

@break60 break60 dismissed stale reviews from CalvinKirs and Technoboy- via 7983589 September 15, 2021 02:59
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 15, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.14%. Comparing base (8694b9c) to head (7983589).
⚠️ Report is 3674 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #6175   +/-   ##
=========================================
  Coverage     39.14%   39.14%           
  Complexity     3250     3250           
=========================================
  Files           638      638           
  Lines         25246    25246           
  Branches       2737     2737           
=========================================
  Hits           9883     9883           
  Misses        14480    14480           
  Partials        883      883           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@break60 break60 changed the title fixBug('#6172') Dag node name value judgment error fixBug('#6172') [UI]Dag node name value judgment error Sep 15, 2021
@wangyizhi1
Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lenboo lenboo merged commit 6aafa81 into apache:dev Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants