Skip to content

Remove unused try block in UT#6182

Merged
davidzollo merged 1 commit intoapache:devfrom
zhongjiajie:rm-unused-try-block
Oct 27, 2021
Merged

Remove unused try block in UT#6182
davidzollo merged 1 commit intoapache:devfrom
zhongjiajie:rm-unused-try-block

Conversation

@zhongjiajie
Copy link
Member

closes #6181

Purpose of the pull request

closes #6181 and remove unused code

@codecov-commenter
Copy link

Codecov Report

Merging #6182 (a256487) into dev (6dedafb) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head a256487 differs from pull request most recent head c2304fb. Consider uploading reports for the commit c2304fb to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #6182      +/-   ##
============================================
- Coverage     39.08%   39.07%   -0.01%     
+ Complexity     3251     3249       -2     
============================================
  Files           637      637              
  Lines         25281    25281              
  Branches       2744     2744              
============================================
- Hits           9880     9878       -2     
  Misses        14520    14520              
- Partials        881      883       +2     
Impacted Files Coverage Δ
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.35% <0.00%> (-1.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dedafb...c2304fb. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@CalvinKirs
Copy link
Member

This UT needs to be modified

@zhongjiajie
Copy link
Member Author

Got it, mean that we should not remove but make it work again. I would try to correct it

Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
good job

Copy link
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo davidzollo merged commit cbeedba into apache:dev Oct 27, 2021
@zhongjiajie zhongjiajie deleted the rm-unused-try-block branch November 5, 2021 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty try block in UT

5 participants