Skip to content

[Bug][API]Resource Check error#6368

Merged
CalvinKirs merged 1 commit intoapache:devfrom
BenjaminWenqiYu:fix-6366
Sep 27, 2021
Merged

[Bug][API]Resource Check error#6368
CalvinKirs merged 1 commit intoapache:devfrom
BenjaminWenqiYu:fix-6366

Conversation

@BenjaminWenqiYu
Copy link
Contributor

Purpose of the pull request

fix the magic number userId '0'

Brief change log

fix the magic number userId '0'

Verify this pull request

This pull request is code cleanup without any test coverage.

resolve #6366

Copy link
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CalvinKirs CalvinKirs changed the title fix the magic number userId '0' [Bug][API]Resource Check error Sep 27, 2021
@CalvinKirs CalvinKirs added the bug Something isn't working label Sep 27, 2021
@CalvinKirs
Copy link
Member

considering that it's your first contribution, I think we can get deep communiction, you can contact me through mail or add wechat(Kris_Evil), when mail or added, please tell me who you are, I think I can help to familiar with the DolphinScheduler if you meet with problems.

@CalvinKirs
Copy link
Member

CI failure has nothing to do with this PR. I will merge this pr first.

@CalvinKirs CalvinKirs merged commit 7413b57 into apache:dev Sep 27, 2021
@BenjaminWenqiYu
Copy link
Contributor Author

Thank you very much, I will add your wechat later.

lenboo added a commit that referenced this pull request Sep 27, 2021
lenboo added a commit that referenced this pull request Sep 27, 2021
This reverts commit 7413b57.

Co-authored-by: OS <29528966+lenboo@users.noreply.github.com>
yc322 pushed a commit to yc322/dolphinscheduler that referenced this pull request Sep 30, 2021
yc322 pushed a commit to yc322/dolphinscheduler that referenced this pull request Sep 30, 2021
This reverts commit 7413b57.

Co-authored-by: OS <29528966+lenboo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [API][service] checkResourceExists function use the magic number userId '0'

2 participants