Skip to content

[#6380][Improvement] the automatically generated spi service name in alert-plugin is wrong #6381

Merged
CalvinKirs merged 1 commit intoapache:devfrom
echohlne:spi-plugin-exception-in-windows
Sep 28, 2021
Merged

[#6380][Improvement] the automatically generated spi service name in alert-plugin is wrong #6381
CalvinKirs merged 1 commit intoapache:devfrom
echohlne:spi-plugin-exception-in-windows

Conversation

@echohlne
Copy link
Contributor

just the same as #5652

The newly introduced spi can't work in windows os.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CalvinKirs CalvinKirs added the win-os windows-os label Sep 28, 2021
@CalvinKirs CalvinKirs merged commit 7dbea92 into apache:dev Sep 28, 2021
yc322 pushed a commit to yc322/dolphinscheduler that referenced this pull request Sep 30, 2021
The newly introduced spi can't work in windows os.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

win-os windows-os

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants