Skip to content

[Fix-6478] [Server] Fix the lack of scheduling time in complement parallelism mode#6491

Merged
CalvinKirs merged 3 commits intoapache:devfrom
zhuangchong:dev-fix-complement-parallel
Oct 11, 2021
Merged

[Fix-6478] [Server] Fix the lack of scheduling time in complement parallelism mode#6491
CalvinKirs merged 3 commits intoapache:devfrom
zhuangchong:dev-fix-complement-parallel

Conversation

@zhuangchong
Copy link
Contributor

Purpose of the pull request

this pr close #6478

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@codecov-commenter
Copy link

Codecov Report

Merging #6491 (788fd15) into dev (59daf3c) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #6491      +/-   ##
============================================
+ Coverage     38.64%   38.71%   +0.06%     
- Complexity     3207     3211       +4     
============================================
  Files           645      645              
  Lines         25729    25728       -1     
  Branches       2786     2785       -1     
============================================
+ Hits           9943     9960      +17     
+ Misses        14870    14851      -19     
- Partials        916      917       +1     
Impacted Files Coverage Δ
...olphinscheduler/service/quartz/cron/CronUtils.java 70.37% <ø> (ø)
...cheduler/api/service/impl/ExecutorServiceImpl.java 48.90% <100.00%> (+0.64%) ⬆️
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...rver/master/processor/queue/TaskResponseEvent.java 100.00% <0.00%> (+6.45%) ⬆️
...er/master/processor/queue/TaskResponseService.java 55.29% <0.00%> (+15.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59daf3c...788fd15. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@zhuangchong zhuangchong requested a review from lenboo October 11, 2021 08:57
Copy link
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@CalvinKirs CalvinKirs merged commit 8869046 into apache:dev Oct 11, 2021
zhuangchong pushed a commit that referenced this pull request Oct 11, 2021
…allelism mode (#6491) (#6498)

* Fix the lack of scheduling time in complement parallelism mode
@zhuangchong zhuangchong deleted the dev-fix-complement-parallel branch October 12, 2021 01:32
lenboo pushed a commit to lenboo/dolphinscheduler that referenced this pull request Oct 12, 2021
…allelism mode (apache#6491)

* fix missing history data

* update code style

* update ExecutorServiceTest test class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [API & SERVICE] Missing history data in complement data mode

4 participants