Skip to content

[DS-6502][MasterServer] fix cmdParam NPE when constructProcessInstance on SCHEDULER mode#6504

Merged
zhuangchong merged 1 commit intoapache:devfrom
caishunfeng:fix_construct_process_instance_npe
Oct 12, 2021
Merged

[DS-6502][MasterServer] fix cmdParam NPE when constructProcessInstance on SCHEDULER mode#6504
zhuangchong merged 1 commit intoapache:devfrom
caishunfeng:fix_construct_process_instance_npe

Conversation

@caishunfeng
Copy link
Contributor

this pr close #6502

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@codecov-commenter
Copy link

Codecov Report

Merging #6504 (25a055e) into dev (db04a5b) will increase coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #6504      +/-   ##
============================================
+ Coverage     38.58%   38.65%   +0.06%     
- Complexity     3205     3210       +5     
============================================
  Files           645      645              
  Lines         25756    25756              
  Branches       2791     2791              
============================================
+ Hits           9938     9955      +17     
+ Misses        14907    14889      -18     
- Partials        911      912       +1     
Impacted Files Coverage Δ
...lphinscheduler/service/process/ProcessService.java 37.22% <0.00%> (ø)
...rver/master/processor/queue/TaskResponseEvent.java 100.00% <0.00%> (+6.45%) ⬆️
...er/master/processor/queue/TaskResponseService.java 55.29% <0.00%> (+15.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db04a5b...25a055e. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

60.0% 60.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zhuangchong zhuangchong merged commit fea7874 into apache:dev Oct 12, 2021
lenboo pushed a commit to lenboo/dolphinscheduler that referenced this pull request Oct 12, 2021
…e on SCHEDULER mode (apache#6504)

Co-authored-by: caishunfeng <534328519@qq.com>
@caishunfeng caishunfeng deleted the fix_construct_process_instance_npe branch December 15, 2021 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [MasterServer] cmdParam NPE when constructProcessInstance on SCHEDULER mode

4 participants