Skip to content

[DS-6606] [fix] [common] JSONUtils#getNodeString String type #6606#6618

Merged
ruanwenjun merged 1 commit intodevfrom
unknown repository
Oct 30, 2021
Merged

[DS-6606] [fix] [common] JSONUtils#getNodeString String type #6606#6618
ruanwenjun merged 1 commit intodevfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Oct 27, 2021

fix #6606
JSONUtils#getNodeString get a value of type String,will get quotes

@ghost ghost changed the title [DS-6606] [fix] [common] JSONUtils#getNodeString String type [DS-6606] [fix] [common] JSONUtils#getNodeString String type #6606 Oct 27, 2021
@CalvinKirs CalvinKirs added the first time contributor First-time contributor label Oct 27, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2021

Codecov Report

Merging #6618 (7927844) into dev (d91801e) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 7927844 differs from pull request most recent head dc3949b. Consider uploading reports for the commit dc3949b to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #6618      +/-   ##
============================================
- Coverage     38.55%   38.51%   -0.05%     
+ Complexity     3224     3222       -2     
============================================
  Files           646      646              
  Lines         25840    25843       +3     
  Branches       2799     2800       +1     
============================================
- Hits           9963     9953      -10     
- Misses        14961    14976      +15     
+ Partials        916      914       -2     
Impacted Files Coverage Δ
...pache/dolphinscheduler/common/utils/JSONUtils.java 73.25% <100.00%> (+0.96%) ⬆️
...ache/dolphinscheduler/server/log/LoggerServer.java 78.26% <0.00%> (-8.70%) ⬇️
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 39.00% <0.00%> (-5.68%) ⬇️
...er/master/processor/queue/TaskResponseService.java 57.31% <0.00%> (-3.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d91801e...dc3949b. Read the comment docs.

ruanwenjun
ruanwenjun previously approved these changes Oct 28, 2021
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost
Copy link
Author

ghost commented Oct 28, 2021

The check failed because nesting of ternary operators was used,please review again ,thx @ruanwenjun @CalvinKirs

Copy link
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@CalvinKirs
Copy link
Member

thanks for your first contribution. good job
please only submit the related resources for this PR, one PR just solves one issue
I think you will need my help, please contact me freely(wechat: Kris_Evil), when added, please tell me your github id

Welcome to join the DolphinScheduler Community!!!

@ruanwenjun ruanwenjun merged commit f60e3c2 into apache:dev Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first time contributor First-time contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [common] JSONUtils#getNodeString get a value of type string with quotes

4 participants