Skip to content

Fix process definitions exists check error#6668

Merged
lenboo merged 2 commits intoapache:devfrom
zhongjiajie:py-gateway-pd-bug
Nov 4, 2021
Merged

Fix process definitions exists check error#6668
lenboo merged 2 commits intoapache:devfrom
zhongjiajie:py-gateway-pd-bug

Conversation

@zhongjiajie
Copy link
Member

This patch fix process definition error when we submit workflow-as-code define

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021

Codecov Report

Merging #6668 (b8afcd3) into dev (3a8b809) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #6668      +/-   ##
============================================
- Coverage     38.49%   38.48%   -0.01%     
- Complexity     3223     3226       +3     
============================================
  Files           646      646              
  Lines         25874    25886      +12     
  Branches       2805     2808       +3     
============================================
+ Hits           9959     9963       +4     
- Misses        15002    15008       +6     
- Partials        913      915       +2     
Impacted Files Coverage Δ
...org/apache/dolphinscheduler/remote/utils/Host.java 40.00% <0.00%> (-2.11%) ⬇️
...pache/dolphinscheduler/dao/upgrade/UpgradeDao.java 4.21% <0.00%> (-0.05%) ⬇️
...scheduler/dao/upgrade/DolphinSchedulerManager.java 0.00% <0.00%> (ø)
...e/dolphinscheduler/remote/NettyRemotingClient.java 53.52% <0.00%> (+1.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a8b809...b8afcd3. Read the comment docs.

@caishunfeng
Copy link
Contributor

LGTM

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ruanwenjun
ruanwenjun previously approved these changes Nov 2, 2021
@zhongjiajie
Copy link
Member Author

Hi, @ruanwenjun I add some log as you said above, PTAL

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lenboo lenboo merged commit 9060f8b into apache:dev Nov 4, 2021
@zhongjiajie zhongjiajie deleted the py-gateway-pd-bug branch November 4, 2021 02:45
@zhongjiajie
Copy link
Member Author

Thanks 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants