Skip to content

[FIX][Standalone Server] check if maven settings.xml not exists#6691

Merged
lenboo merged 1 commit intoapache:devfrom
LiuBodong:fix-6689
Nov 4, 2021
Merged

[FIX][Standalone Server] check if maven settings.xml not exists#6691
lenboo merged 1 commit intoapache:devfrom
LiuBodong:fix-6689

Conversation

@LiuBodong
Copy link
Contributor

Purpose of the pull request

resolves #6689

@codecov-commenter
Copy link

Codecov Report

Merging #6691 (3359dfc) into dev (61a8726) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #6691      +/-   ##
============================================
- Coverage     38.41%   38.39%   -0.03%     
+ Complexity     3227     3223       -4     
============================================
  Files           646      646              
  Lines         25936    25936              
  Branches       2817     2817              
============================================
- Hits           9964     9957       -7     
- Misses        15058    15065       +7     
  Partials        914      914              
Impacted Files Coverage Δ
...heduler/spi/plugin/DolphinPluginManagerConfig.java 0.00% <0.00%> (ø)
...ache/dolphinscheduler/server/log/LoggerServer.java 78.26% <0.00%> (-8.70%) ⬇️
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...org/apache/dolphinscheduler/remote/utils/Host.java 37.77% <0.00%> (-2.23%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.35% <0.00%> (-1.70%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 52.11% <0.00%> (-1.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61a8726...3359dfc. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CalvinKirs CalvinKirs added this to the 2.0.0-release milestone Nov 4, 2021
Copy link
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lenboo lenboo merged commit 71047db into apache:dev Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [Standalone Server] DolphinPluginManagerConfig get maven sttings does not check file exists

4 participants