Revert "Change the number of approving_review_count to 2 (#6456)"#6706
Merged
CalvinKirs merged 1 commit intoapache:devfrom Nov 5, 2021
Merged
Revert "Change the number of approving_review_count to 2 (#6456)"#6706CalvinKirs merged 1 commit intoapache:devfrom
CalvinKirs merged 1 commit intoapache:devfrom
Conversation
This reverts commit 4d69685
Member
Author
|
PTAL @dailidong @lenboo @CalvinKirs @zhuangchong @ruanwenjun |
Member
Author
|
haha, I still can not merge with one approval until this patch is merged @zhuangchong |
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 4d69685
When approver up to 2, we find our PR merge more slower than before, and it will lost some contributors connection. So this patch revert approver number change.