Skip to content

[Bug][Master] The task of dependent should use taskCode#6730

Merged
CalvinKirs merged 4 commits intoapache:devfrom
lenboo:dev-6682
Nov 7, 2021
Merged

[Bug][Master] The task of dependent should use taskCode#6730
CalvinKirs merged 4 commits intoapache:devfrom
lenboo:dev-6682

Conversation

@lenboo
Copy link
Contributor

@lenboo lenboo commented Nov 7, 2021

close #6682

change task code instead of task name.

@codecov-commenter
Copy link

Codecov Report

Merging #6730 (d02a77f) into dev (d27c6ea) will increase coverage by 0.01%.
The diff coverage is 4.54%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #6730      +/-   ##
============================================
+ Coverage     37.92%   37.93%   +0.01%     
- Complexity     3236     3238       +2     
============================================
  Files           642      642              
  Lines         26383    26383              
  Branches       2859     2859              
============================================
+ Hits          10005    10008       +3     
+ Misses        15460    15455       -5     
- Partials        918      920       +2     
Impacted Files Coverage Δ
.../org/apache/dolphinscheduler/common/Constants.java 79.16% <ø> (ø)
...e/dolphinscheduler/common/model/DependentItem.java 0.00% <0.00%> (ø)
...g/apache/dolphinscheduler/dao/utils/DagHelper.java 47.77% <0.00%> (ø)
...er/server/master/runner/WorkflowExecuteThread.java 0.15% <0.00%> (ø)
...ver/master/runner/task/ConditionTaskProcessor.java 0.00% <0.00%> (ø)
...olphinscheduler/server/utils/DependentExecute.java 0.00% <0.00%> (ø)
...lphinscheduler/service/process/ProcessService.java 38.73% <0.00%> (ø)
...cheduler/api/service/impl/ExecutorServiceImpl.java 49.36% <100.00%> (ø)
...e/dolphinscheduler/remote/NettyRemotingClient.java 53.52% <0.00%> (+1.40%) ⬆️
...org/apache/dolphinscheduler/remote/utils/Host.java 40.00% <0.00%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d27c6ea...d02a77f. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

2.8% 2.8% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@brave-lee brave-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CalvinKirs CalvinKirs merged commit 24bd8a1 into apache:dev Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [UI/Master] The task of dependent should use taskCode

4 participants