Skip to content

[Improvement#6655] [UI] remove registry monitor #6789

Merged
CalvinKirs merged 6 commits intoapache:devfrom
981433814:dev
Nov 11, 2021
Merged

[Improvement#6655] [UI] remove registry monitor #6789
CalvinKirs merged 6 commits intoapache:devfrom
981433814:dev

Conversation

@981433814
Copy link
Contributor

@981433814 981433814 commented Nov 11, 2021

remove zkmonitor

this close #6655

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2021

Codecov Report

Merging #6789 (9e1152d) into dev (c110488) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #6789      +/-   ##
============================================
- Coverage     41.81%   41.79%   -0.02%     
+ Complexity     3616     3613       -3     
============================================
  Files           641      641              
  Lines         25897    25890       -7     
  Branches       2795     2795              
============================================
- Hits          10830    10822       -8     
  Misses        14088    14088              
- Partials        979      980       +1     
Impacted Files Coverage Δ
...hinscheduler/api/controller/MonitorController.java 100.00% <ø> (ø)
.../org/apache/dolphinscheduler/api/enums/Status.java 100.00% <ø> (ø)
...scheduler/api/service/impl/MonitorServiceImpl.java 66.66% <ø> (-3.11%) ⬇️
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c110488...9e1152d. Read the comment docs.

zhuangchong
zhuangchong previously approved these changes Nov 11, 2021
Copy link
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@CalvinKirs CalvinKirs added this to the 2.0.0-release milestone Nov 11, 2021
@CalvinKirs CalvinKirs changed the title [DS-6655][fix] remove zkmonitor [Improvement#6655] [UI] remove registry monitor Nov 11, 2021
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove the backend API

- remove all backend API
@981433814
Copy link
Contributor Author

Please also remove the backend API

ok, I have removed all backend API

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [server-zkmonitor] zkmonitor can't show for normal

5 participants