Skip to content

[Fix-6854][dao] Fix extra 'and' in ResourceMapper.xml#6876

Merged
davidzollo merged 2 commits intoapache:devfrom
DingPengfei:dev
Nov 17, 2021
Merged

[Fix-6854][dao] Fix extra 'and' in ResourceMapper.xml#6876
davidzollo merged 2 commits intoapache:devfrom
DingPengfei:dev

Conversation

@DingPengfei
Copy link
Contributor

Purpose of the pull request

Brief change log

fix bug of extra 'and' in "queryResourcePaging" of ResourceMapper.xml

Verify this pull request

This pull request is code cleanup without any test coverage.

@codecov-commenter
Copy link

Codecov Report

Merging #6876 (fe84e36) into dev (adcf5b3) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev    #6876   +/-   ##
=========================================
  Coverage     33.06%   33.07%           
+ Complexity     1621     1618    -3     
=========================================
  Files           433      433           
  Lines         14292    14292           
  Branches       1427     1427           
=========================================
+ Hits           4726     4727    +1     
  Misses         9115     9115           
+ Partials        451      450    -1     
Impacted Files Coverage Δ
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...org/apache/dolphinscheduler/remote/utils/Host.java 37.77% <0.00%> (-2.23%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 52.11% <0.00%> (-1.41%) ⬇️
...er/server/master/runner/WorkflowExecuteThread.java 11.46% <0.00%> (+0.15%) ⬆️
...olphinscheduler/rpc/remote/NettyClientHandler.java 51.16% <0.00%> (+9.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54933b3...fe84e36. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@davidzollo davidzollo added the first time contributor First-time contributor label Nov 17, 2021
Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
good job

@davidzollo

This comment has been minimized.

@davidzollo davidzollo merged commit 842c385 into apache:dev Nov 17, 2021
@lenboo lenboo added this to the 2.0.0-release milestone Nov 17, 2021
lenboo pushed a commit that referenced this pull request Nov 17, 2021
Co-authored-by: ding <dingpf@helowin>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first time contributor First-time contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants