Skip to content

[Improvement][Datasource]refactor datasource parsing other parameter#6903

Closed
jon-qj wants to merge 4 commits intoapache:devfrom
jon-qj:dev-new2
Closed

[Improvement][Datasource]refactor datasource parsing other parameter#6903
jon-qj wants to merge 4 commits intoapache:devfrom
jon-qj:dev-new2

Conversation

@jon-qj
Copy link
Contributor

@jon-qj jon-qj commented Nov 18, 2021

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@codecov-commenter
Copy link

Codecov Report

Merging #6903 (0337b37) into dev (9113817) will decrease coverage by 8.60%.
The diff coverage is 76.08%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #6903      +/-   ##
============================================
- Coverage     41.83%   33.23%   -8.61%     
+ Complexity     3618     1614    -2004     
============================================
  Files           641      433     -208     
  Lines         25895    14231   -11664     
  Branches       2795     1429    -1366     
============================================
- Hits          10833     4729    -6104     
+ Misses        14081     9058    -5023     
+ Partials        981      444     -537     
Impacted Files Coverage Δ
...g/apache/dolphinscheduler/spi/utils/Constants.java 0.00% <ø> (ø)
...urce/clickhouse/ClickHouseDatasourceProcessor.java 60.52% <50.00%> (+8.52%) ⬆️
...rce/api/datasource/db2/Db2DatasourceProcessor.java 56.75% <50.00%> (+5.73%) ⬆️
...e/api/datasource/hive/HiveDatasourceProcessor.java 38.88% <50.00%> (+1.98%) ⬆️
...i/datasource/oracle/OracleDatasourceProcessor.java 51.11% <50.00%> (+5.49%) ⬆️
...urce/postgresql/PostgreSqlDatasourceProcessor.java 55.26% <50.00%> (+7.26%) ⬆️
...i/datasource/presto/PrestoDatasourceProcessor.java 56.75% <50.00%> (+7.77%) ⬆️
...api/datasource/spark/SparkDatasourceProcessor.java 44.64% <50.00%> (+3.46%) ⬆️
...source/sqlserver/SqlServerDatasourceProcessor.java 54.05% <50.00%> (+6.13%) ⬆️
...ce/api/datasource/AbstractDatasourceProcessor.java 77.08% <88.00%> (+11.86%) ⬆️
... and 252 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9113817...0337b37. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

84.3% 84.3% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Mar 23, 2022
@github-actions
Copy link

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.

@github-actions github-actions bot closed this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants