Skip to content

[DS-6891][MasterServer] reduce db operation when process instance running#6904

Merged
lenboo merged 7 commits intoapache:devfrom
caishunfeng:cache
Nov 19, 2021
Merged

[DS-6891][MasterServer] reduce db operation when process instance running#6904
lenboo merged 7 commits intoapache:devfrom
caishunfeng:cache

Conversation

@caishunfeng
Copy link
Contributor

@caishunfeng caishunfeng commented Nov 18, 2021

#6891

Brief change log

  • use workflow memory cache instead of selecting processInstance and taskInstance from DB each time
  • reduce the repeat query
  • remove the old design TaskInstanceCacheManager

@caishunfeng caishunfeng changed the title [WIP][DS-6891][MasterServer] reduce db operation when process instance running [DS-6891][MasterServer] reduce db operation when process instance running Nov 18, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021

Codecov Report

Merging #6904 (eacfad0) into dev (595e484) will decrease coverage by 0.21%.
The diff coverage is 23.17%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #6904      +/-   ##
============================================
- Coverage     33.07%   32.85%   -0.22%     
+ Complexity     1626     1624       -2     
============================================
  Files           433      432       -1     
  Lines         14365    14380      +15     
  Branches       1437     1446       +9     
============================================
- Hits           4751     4725      -26     
- Misses         9158     9200      +42     
+ Partials        456      455       -1     
Impacted Files Coverage Δ
...ver/master/consumer/TaskPriorityQueueConsumer.java 0.00% <0.00%> (ø)
...uler/server/master/processor/TaskAckProcessor.java 23.52% <ø> (-2.79%) ⬇️
...server/master/processor/TaskResponseProcessor.java 0.00% <ø> (ø)
...ter/processor/queue/StateEventResponseService.java 0.00% <0.00%> (ø)
...r/server/master/runner/task/BaseTaskProcessor.java 5.22% <0.00%> (+0.07%) ⬆️
...server/master/runner/task/CommonTaskProcessor.java 6.45% <0.00%> (ø)
...ver/master/runner/task/ConditionTaskProcessor.java 0.00% <0.00%> (ø)
...ver/master/runner/task/DependentTaskProcessor.java 0.00% <0.00%> (ø)
...er/server/master/runner/task/SubTaskProcessor.java 0.00% <0.00%> (ø)
...server/master/runner/task/SwitchTaskProcessor.java 0.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 595e484...eacfad0. Read the comment docs.

Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test requests change

zhongjiajie
zhongjiajie previously approved these changes Nov 19, 2021
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

18.3% 18.3% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lenboo lenboo merged commit 28872d8 into apache:dev Nov 19, 2021
@caishunfeng caishunfeng deleted the cache branch February 17, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants