Skip to content

[python] Add ut cover process definitions separate mode#6908

Merged
CalvinKirs merged 3 commits intoapache:devfrom
zhongjiajie:t-task-define-outside-pd
Nov 19, 2021
Merged

[python] Add ut cover process definitions separate mode#6908
CalvinKirs merged 3 commits intoapache:devfrom
zhongjiajie:t-task-define-outside-pd

Conversation

@zhongjiajie
Copy link
Member

Add test in situation process definition in separate mode which mean task define with explicit assign process definition to task

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021

Codecov Report

Merging #6908 (5bbd996) into dev (0dce68e) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #6908      +/-   ##
============================================
- Coverage     33.00%   32.98%   -0.03%     
+ Complexity     1622     1621       -1     
============================================
  Files           433      433              
  Lines         14362    14362              
  Branches       1437     1437              
============================================
- Hits           4740     4737       -3     
- Misses         9168     9170       +2     
- Partials        454      455       +1     
Impacted Files Coverage Δ
...e/dolphinscheduler/remote/NettyRemotingClient.java 50.70% <0.00%> (-2.82%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 83.05% <0.00%> (+1.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dce68e...5bbd996. Read the comment docs.

@zhongjiajie zhongjiajie force-pushed the t-task-define-outside-pd branch from 3b39a59 to 5bbd996 Compare November 19, 2021 08:49
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CalvinKirs CalvinKirs merged commit 6e812be into apache:dev Nov 19, 2021
@zhongjiajie zhongjiajie deleted the t-task-define-outside-pd branch November 19, 2021 09:34
@zhongjiajie
Copy link
Member Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants