[Fix][Common] rewrite code generate,fix bit shift#6914
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #6914 +/- ##
============================================
- Coverage 33.10% 32.98% -0.12%
- Complexity 1620 1622 +2
============================================
Files 433 433
Lines 14307 14362 +55
Branches 1428 1437 +9
============================================
+ Hits 4737 4738 +1
- Misses 9118 9170 +52
- Partials 452 454 +2
Continue to review full report at Codecov.
|
Contributor
|
If we use Snowflake's id generation algorithm, we declare that we have used it, this PR is not a good solution, I will close it |
kezhenxu94
reviewed
Nov 19, 2021
| DolphinPluginDiscovery from https://github.com/prestosql/presto Apache 2.0 | ||
| DolphinPluginLoader from https://github.com/prestosql/presto Apache 2.0 | ||
|
|
||
| CodeGenerateUtils from https://github.com/twitter-archive/snowflake/blob/snowflake-2010 Apache 2.0 |
Member
There was a problem hiding this comment.
This link is 404 for me,
Suggested change
| CodeGenerateUtils from https://github.com/twitter-archive/snowflake/blob/snowflake-2010 Apache 2.0 | |
| CodeGenerateUtils from https://github.com/twitter-archive/snowflake/tree/snowflake-2010 Apache 2.0 |
|
Kudos, SonarCloud Quality Gate passed! |
lenboo
pushed a commit
to lenboo/dolphinscheduler
that referenced
this pull request
Nov 19, 2021
* rewrite code generate,fix bit shift * fix ut * add algorithm from licenses file * add algorithm from licenses file * add algorithm from licenses file * add algorithm from licenses file * add algorithm from licenses file * fix ut # Conflicts: # dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/EnvironmentServiceImpl.java # dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java # dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/CodeGenerateUtilsTest.java # dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/upgrade/UpgradeDao.java # dolphinscheduler-dist/release-docs/LICENSE # dolphinscheduler-python/src/main/java/org/apache/dolphinscheduler/server/PythonGatewayServer.java # dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
lenboo
added a commit
to lenboo/dolphinscheduler
that referenced
this pull request
Nov 19, 2021
* rewrite code generate,fix bit shift * fix ut * add algorithm from licenses file * add algorithm from licenses file * add algorithm from licenses file * add algorithm from licenses file * add algorithm from licenses file * fix ut # Conflicts: # dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/EnvironmentServiceImpl.java # dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java # dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/CodeGenerateUtilsTest.java # dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/upgrade/UpgradeDao.java # dolphinscheduler-dist/release-docs/LICENSE # dolphinscheduler-python/src/main/java/org/apache/dolphinscheduler/server/PythonGatewayServer.java # dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
lenboo
added a commit
to lenboo/dolphinscheduler
that referenced
this pull request
Nov 19, 2021
* rewrite code generate,fix bit shift * fix ut * add algorithm from licenses file * add algorithm from licenses file * add algorithm from licenses file * add algorithm from licenses file * add algorithm from licenses file * fix ut # Conflicts: # dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/EnvironmentServiceImpl.java # dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java # dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/CodeGenerateUtilsTest.java # dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/upgrade/UpgradeDao.java # dolphinscheduler-dist/release-docs/LICENSE # dolphinscheduler-python/src/main/java/org/apache/dolphinscheduler/server/PythonGatewayServer.java # dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
lenboo
added a commit
to lenboo/dolphinscheduler
that referenced
this pull request
Nov 19, 2021
* rewrite code generate,fix bit shift * fix ut * add algorithm from licenses file * add algorithm from licenses file * add algorithm from licenses file * add algorithm from licenses file * add algorithm from licenses file * fix ut # Conflicts: # dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/EnvironmentServiceImpl.java # dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java # dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/CodeGenerateUtilsTest.java # dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/upgrade/UpgradeDao.java # dolphinscheduler-dist/release-docs/LICENSE # dolphinscheduler-python/src/main/java/org/apache/dolphinscheduler/server/PythonGatewayServer.java # dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
lenboo
added a commit
that referenced
this pull request
Nov 19, 2021
* [Fix][Common] rewrite code generate,fix bit shift (#6914) * rewrite code generate,fix bit shift * fix ut * add algorithm from licenses file * add algorithm from licenses file * add algorithm from licenses file * add algorithm from licenses file * add algorithm from licenses file * fix ut # Conflicts: # dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/EnvironmentServiceImpl.java # dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java # dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/CodeGenerateUtilsTest.java # dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/upgrade/UpgradeDao.java # dolphinscheduler-dist/release-docs/LICENSE # dolphinscheduler-python/src/main/java/org/apache/dolphinscheduler/server/PythonGatewayServer.java # dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java * [Fix][Common] rewrite code generate,fix bit shift (#6914) * rewrite code generate,fix bit shift * fix ut * add algorithm from licenses file * add algorithm from licenses file * add algorithm from licenses file * add algorithm from licenses file * add algorithm from licenses file * fix ut # Conflicts: # dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/EnvironmentServiceImpl.java # dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java # dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/CodeGenerateUtilsTest.java # dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/upgrade/UpgradeDao.java # dolphinscheduler-dist/release-docs/LICENSE # dolphinscheduler-python/src/main/java/org/apache/dolphinscheduler/server/PythonGatewayServer.java # dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java * [Fix][Common] rewrite code generate,fix bit shift (#6914) * rewrite code generate,fix bit shift * fix ut * add algorithm from licenses file * add algorithm from licenses file * add algorithm from licenses file * add algorithm from licenses file * add algorithm from licenses file * fix ut # Conflicts: # dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/EnvironmentServiceImpl.java # dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java # dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/CodeGenerateUtilsTest.java # dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/upgrade/UpgradeDao.java # dolphinscheduler-dist/release-docs/LICENSE # dolphinscheduler-python/src/main/java/org/apache/dolphinscheduler/server/PythonGatewayServer.java # dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java * [Fix][Common] rewrite code generate,fix bit shift (#6914) * rewrite code generate,fix bit shift * fix ut * add algorithm from licenses file * add algorithm from licenses file * add algorithm from licenses file * add algorithm from licenses file * add algorithm from licenses file * fix ut # Conflicts: # dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/EnvironmentServiceImpl.java # dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java # dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/CodeGenerateUtilsTest.java # dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/upgrade/UpgradeDao.java # dolphinscheduler-dist/release-docs/LICENSE # dolphinscheduler-python/src/main/java/org/apache/dolphinscheduler/server/PythonGatewayServer.java # dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java Co-authored-by: JinYong Li <42576980+JinyLeeChina@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6912
fix code bit shift error