Skip to content

[Improvement][Dao] SQL optimization - limit one piece of data #5061#6940

Merged
CalvinKirs merged 8 commits intoapache:devfrom
Linkaiup:dev_linkai_optimize_dao
Nov 22, 2021
Merged

[Improvement][Dao] SQL optimization - limit one piece of data #5061#6940
CalvinKirs merged 8 commits intoapache:devfrom
Linkaiup:dev_linkai_optimize_dao

Conversation

@Linkaiup
Copy link
Copy Markdown
Contributor

@Linkaiup Linkaiup commented Nov 21, 2021

Purpose of the pull request

See #5061

This pull request improvement the PluginDefineMapper dao

Brief change log

1.Change from select all data to limit one piece of data
2.Change the Test code too.

Verify this pull request

This pull request is already covered by existing tests, such as (PluginDefineTest.testQueryByNameAndType).

@Linkaiup Linkaiup changed the title [Improvement][Dao] SQL optimization - limit one piece of data #5069 [Improvement][Dao] SQL optimization - limit one piece of data #5061 Nov 21, 2021
@Linkaiup
Copy link
Copy Markdown
Contributor Author

@CalvinKirs Looking forward to your code review!

caishunfeng
caishunfeng previously approved these changes Nov 22, 2021
Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Linkaiup
Copy link
Copy Markdown
Contributor Author

LGTM

could you please approve to run workflow for this PR?@caishunfeng

CalvinKirs
CalvinKirs previously approved these changes Nov 22, 2021
@davidzollo
Copy link
Copy Markdown
Contributor

LGTM

could you please approve to run workflow for this PR?@caishunfeng

done, it's running

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #6940 (905de58) into dev (d2666d6) will decrease coverage by 0.11%.
The diff coverage is n/a.

❗ Current head 905de58 differs from pull request most recent head b882eef. Consider uploading reports for the commit b882eef to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #6940      +/-   ##
============================================
- Coverage     32.87%   32.76%   -0.12%     
+ Complexity     1624     1618       -6     
============================================
  Files           432      432              
  Lines         14377    14377              
  Branches       1446     1446              
============================================
- Hits           4727     4710      -17     
- Misses         9196     9212      +16     
- Partials        454      455       +1     
Impacted Files Coverage Δ
...he/dolphinscheduler/common/enums/SqoopJobType.java 0.00% <0.00%> (-88.89%) ⬇️
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...er/master/processor/queue/TaskResponseService.java 60.67% <0.00%> (-3.38%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 50.70% <0.00%> (-2.82%) ⬇️
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (-2.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2666d6...b882eef. Read the comment docs.

@Linkaiup Linkaiup dismissed stale reviews from CalvinKirs and caishunfeng via 3293431 November 22, 2021 08:42
@Linkaiup
Copy link
Copy Markdown
Contributor Author

I improve some code to get A rate for sonarcloud @dailidong @CalvinKirs @caishunfeng I submited the code again

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Linkaiup
Copy link
Copy Markdown
Contributor Author

Now, I modified the PR according to sonarcloud prompts and re-push the code~ Please review again@CalvinKirs @caishunfeng

@CalvinKirs CalvinKirs merged commit ad33d43 into apache:dev Nov 22, 2021
@CalvinKirs CalvinKirs added this to the 2.0.1-release milestone Nov 22, 2021
@CalvinKirs
Copy link
Copy Markdown
Member

thanks for your first contribution, I'm looking forward to see your deep participation, if you meet any question, please contact me through my wechat(Kris_Evil), please tell me your github id when added

@Linkaiup
Copy link
Copy Markdown
Contributor Author

thanks for your first contribution, I'm looking forward to see your deep participation, if you meet any question, please contact me through my wechat(Kris_Evil), please tell me your github id when added

Thank you for your affirmation! In my spare time, I will continue to pay attention to the dynamics of the DS community and continue to contribute my own strength!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first time contributor First-time contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants