Skip to content

Fix master registry bug#6944

Closed
rewerma wants to merge 2 commits intoapache:devfrom
rewerma:dev
Closed

Fix master registry bug#6944
rewerma wants to merge 2 commits intoapache:devfrom
rewerma:dev

Conversation

@rewerma
Copy link

@rewerma rewerma commented Nov 21, 2021

Purpose of the pull request

This pull request adds the threadsafe for Master registry and fix the slot distribution bug.

@codecov-commenter
Copy link

Codecov Report

Merging #6944 (3138cd4) into dev (94f6c5c) will decrease coverage by 0.08%.
The diff coverage is 14.28%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #6944      +/-   ##
============================================
- Coverage     33.14%   33.06%   -0.09%     
+ Complexity     1622     1618       -4     
============================================
  Files           433      433              
  Lines         14290    14290              
  Branches       1426     1426              
============================================
- Hits           4737     4725      -12     
- Misses         9101     9116      +15     
+ Partials        452      449       -3     
Impacted Files Coverage Δ
...inscheduler/service/queue/MasterPriorityQueue.java 0.00% <0.00%> (ø)
...uler/server/master/registry/ServerNodeManager.java 1.29% <33.33%> (ø)
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 47.27% <0.00%> (-7.28%) ⬇️
...org/apache/dolphinscheduler/remote/utils/Host.java 37.77% <0.00%> (-2.23%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.35% <0.00%> (-1.70%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 52.11% <0.00%> (-1.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94f6c5c...3138cd4. Read the comment docs.

@zhuangchong zhuangchong added the first time contributor First-time contributor label Nov 22, 2021
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 5 Code Smells

11.1% 11.1% Coverage
0.0% 0.0% Duplication

@caishunfeng
Copy link
Contributor

hi @rewerma , please see the sonar analysis and make UTpass.

@kezhenxu94
Copy link
Member

No update for nearly a month, and there are conflicts, I'm closing, if @rewerma you are back to this work, feel free to reopen

@kezhenxu94 kezhenxu94 closed this Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first time contributor First-time contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants