Skip to content

[Feature-6996][server & ui] Add dependent tips about success or failure#6997

Closed
shangeyao wants to merge 5 commits intoapache:devfrom
shangeyao:feature-6996
Closed

[Feature-6996][server & ui] Add dependent tips about success or failure#6997
shangeyao wants to merge 5 commits intoapache:devfrom
shangeyao:feature-6996

Conversation

@shangeyao
Copy link
Contributor

@shangeyao shangeyao commented Nov 25, 2021

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2021

Codecov Report

Merging #6997 (bd19998) into dev (e6fe39e) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #6997      +/-   ##
============================================
- Coverage     32.78%   32.66%   -0.13%     
+ Complexity     1621     1606      -15     
============================================
  Files           432      431       -1     
  Lines         14385    14344      -41     
  Branches       1446     1437       -9     
============================================
- Hits           4716     4685      -31     
+ Misses         9217     9207      -10     
  Partials        452      452              
Impacted Files Coverage Δ
...ver/master/runner/task/DependentTaskProcessor.java 0.00% <0.00%> (ø)
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...che/dolphinscheduler/common/utils/SchemaUtils.java
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 54.54% <0.00%> (+7.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6fe39e...bd19998. Read the comment docs.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I seems the main change is for UI, @songjianet please review this pr, thx.

}
})
}
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, this problem may be caused by my previous refactoring.
BTW, if there are multiple DEPENDENT tasks in a workflow, problems may arise here. You can consider using
taskInstance computed in formModel.vue to obtain the dependentResult of the current instance.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a mistake. Sorry, there's no problem here.

Copy link
Member

@wangyizhi1 wangyizhi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@caishunfeng
Copy link
Contributor

@shangeyao please resolve the conflicts.

@shangeyao shangeyao closed this Dec 23, 2021
@shangeyao
Copy link
Contributor Author

New PR was related to #7571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants