[WIP] Upgrade mysql jdbc class name to later and avoid regression#7410
[WIP] Upgrade mysql jdbc class name to later and avoid regression#7410zhongjiajie wants to merge 1 commit intoapache:devfrom
Conversation
Not only upgrade to later version but also add to checkstyle to avoid regression. closes: apache#7354
zhongjiajie
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #7410 +/- ##
============================================
- Coverage 41.29% 41.27% -0.02%
Complexity 3664 3664
============================================
Files 634 634
Lines 26397 26399 +2
Branches 2957 2958 +1
============================================
- Hits 10900 10896 -4
- Misses 14470 14477 +7
+ Partials 1027 1026 -1
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
| activate: | ||
| on-profile: mysql | ||
| # TODO Add this to test check style | ||
| driver-class-name: com.mysql.jdbc.Driver |
There was a problem hiding this comment.
I add this line to test whether check style could find it and raise error, but failed. Did I miss something?
There was a problem hiding this comment.
It seems that the check style will not effect config file.
There was a problem hiding this comment.
I found out it have parameter in https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html#resourceIncludes could check file in resource dir. I change the file ext from properties to yaml but I still failed
|
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs. |
|
remote stale |
|
close due to #10220 |
3 participants
Not only upgrade to later version but also add to checkstyle
to avoid regression.
closes: #7354