[Feature-7572][Server & ui] Add Backward Dependent Execution#7579
Closed
shangeyao wants to merge 2 commits into
Closed
[Feature-7572][Server & ui] Add Backward Dependent Execution#7579shangeyao wants to merge 2 commits into
shangeyao wants to merge 2 commits into
Conversation
Contributor
Author
|
At present, only "ALL" is considered. |
3 tasks
|
SonarCloud Quality Gate failed. |
caishunfeng
reviewed
Dec 23, 2021
| from t_ds_process_task_relation | ||
| WHERE pre_task_code = #{taskCode} | ||
| <if test="taskCode != 0"> | ||
| or post_task_code = #{taskCode} |
Contributor
There was a problem hiding this comment.
I think it's better to split this sql instread of or query, which will dismatch index.
| List<TaskDefinition> definitionList = taskDefinitionLogMapper.queryDefinitionListByTaskType(TaskType.DEPENDENT.getDesc()); | ||
| for (TaskDefinition taskDefinition : definitionList) { | ||
| String dependence = taskDefinition.getDependence(); | ||
| ArrayNode dependTaskList = (ArrayNode) new ObjectMapper().readTree(dependence).get("dependTaskList"); |
Contributor
There was a problem hiding this comment.
It's better to use constant "dependTaskList"
| String dependence = taskDefinition.getDependence(); | ||
| ArrayNode dependTaskList = (ArrayNode) new ObjectMapper().readTree(dependence).get("dependTaskList"); | ||
| for (JsonNode dependTask : dependTaskList) { | ||
| ArrayNode dependItemList = (ArrayNode) dependTask.get("dependItemList"); |
Contributor
There was a problem hiding this comment.
It's better to use constant
Member
|
Thank you for your contribution, but it is currently in the switching period between the new and the old UI, and this function will not be implemented in the old UI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The downstream dependency is queried according to the dependent node, and the execution is triggered automatically.
#7572