[Feat]Restore presto and spark sql datasource in datasource plugin module#7619
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #7619 +/- ##
============================================
- Coverage 41.34% 41.02% -0.32%
+ Complexity 3678 3670 -8
============================================
Files 641 648 +7
Lines 26473 26613 +140
Branches 2961 2967 +6
============================================
- Hits 10944 10917 -27
- Misses 14502 14669 +167
Partials 1027 1027
Continue to review full report at Codecov.
|
|
SonarCloud Quality Gate failed. |
|
@sparklezzz |
|
Looking forward to an early merger. we can't config the presto connection now after upgrading to version 2.0.3, |
|
Maybe we can expose the jdbcUrl parameter without ds assembling it by ourselves, which can reduce a lot of repetitive code, and can reuse the same logic like hive, presto, spark, etc. |
Narcasserun
left a comment
There was a problem hiding this comment.
There are a lot of duplicate codes in hive, Presto and spark data sources. Maybe we should reuse logic
|
Hi @sparklezzz I have the same problem. When can you come back? |
|
Kudos, SonarCloud Quality Gate passed! |











Purpose of the pull request
Restore presto sql and spark sql datasource in datasource plugin module, which were removed during refactor in v2.0.1
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows: