[python] Fix database error handler about no datasource name#7631
Merged
CalvinKirs merged 3 commits intoapache:devfrom Jan 7, 2022
Merged
[python] Fix database error handler about no datasource name#7631CalvinKirs merged 3 commits intoapache:devfrom
CalvinKirs merged 3 commits intoapache:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #7631 +/- ##
============================================
- Coverage 41.03% 41.00% -0.03%
+ Complexity 3696 3695 -1
============================================
Files 637 637
Lines 27025 27044 +19
Branches 3063 3067 +4
============================================
Hits 11090 11090
- Misses 14867 14885 +18
- Partials 1068 1069 +1
Continue to review full report at Codecov.
|
0821abc to
f84047d
Compare
Member
Author
|
@devosend PTAL, if you have time, thanks. |
devosend
reviewed
Jan 5, 2022
dolphinscheduler-python/pydolphinscheduler/src/pydolphinscheduler/core/database.py
Outdated
Show resolved
Hide resolved
The original code show too many unrelated log when database name do not exists. BTW, it would continue the code when error miss. This patch is try to fix it. close: apache#7616
f84047d to
63de7af
Compare
Member
Author
|
I here allow it raise error base on py4j jave gateway server track stack, and I directly using chaining error message for more easy location the error. You could see in keyword Here it is an example |
Member
Author
|
PTAL @devosend |
|
Kudos, SonarCloud Quality Gate passed! |
Contributor
LGTM @zhongjiajie |
Member
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








The original code show too many unrelated log when database name
do not exists. BTW, it would continue the code when error miss.
This patch is try to fix it.
close: #7616