Skip to content

Add E2E case for user manage#7652

Merged
kezhenxu94 merged 1 commit intodevfrom
user_e2e
Dec 28, 2021
Merged

Add E2E case for user manage#7652
kezhenxu94 merged 1 commit intodevfrom
user_e2e

Conversation

@kezhenxu94
Copy link
Copy Markdown
Member

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

caishunfeng
caishunfeng previously approved these changes Dec 27, 2021
Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 27, 2021

Codecov Report

Merging #7652 (5e2b3a9) into dev (cc8fbe3) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #7652      +/-   ##
============================================
- Coverage     41.14%   41.13%   -0.01%     
- Complexity     3663     3664       +1     
============================================
  Files           641      641              
  Lines         26540    26555      +15     
  Branches       2967     2972       +5     
============================================
+ Hits          10920    10924       +4     
- Misses        14590    14601      +11     
  Partials       1030     1030              
Impacted Files Coverage Δ
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...api/service/impl/ProcessDefinitionServiceImpl.java 25.91% <0.00%> (-0.13%) ⬇️
...lphinscheduler/service/process/ProcessService.java 35.22% <0.00%> (-0.07%) ⬇️
.../org/apache/dolphinscheduler/api/enums/Status.java 100.00% <0.00%> (ø)
...e/dolphinscheduler/remote/NettyRemotingClient.java 53.52% <0.00%> (+0.70%) ⬆️
...er/master/dispatch/host/assign/RandomSelector.java 83.33% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc8fbe3...5e2b3a9. Read the comment docs.

@zhongjiajie
Copy link
Copy Markdown
Member

It seems the e2e test failed

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, my friend

@kezhenxu94 kezhenxu94 merged commit 269a624 into dev Dec 28, 2021
@kezhenxu94 kezhenxu94 deleted the user_e2e branch December 28, 2021 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e e2e test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants