[Fix-7654]Dependent node onChangeProjectCode error#7672
Merged
brave-lee merged 5 commits intoapache:devfrom Dec 28, 2021
Merged
[Fix-7654]Dependent node onChangeProjectCode error#7672brave-lee merged 5 commits intoapache:devfrom
brave-lee merged 5 commits intoapache:devfrom
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
caishunfeng
reviewed
Dec 28, 2021
| putMsg(result, Status.PROCESS_DEFINE_NOT_EXIST, codes); | ||
| return result; | ||
| } | ||
| HashMap<Long, Project> userProjects = new HashMap(Constants.DEFAULT_HASH_MAP_SIZE); |
Contributor
There was a problem hiding this comment.
It's better to set the map size by db query result.
Contributor
Author
There was a problem hiding this comment.
It's better to set the map size by db query result.
It's just a default initialize value, and the hash map size can be extended automatically.
lenboo
added a commit
to lenboo/dolphinscheduler
that referenced
this pull request
Dec 28, 2021
* fix apache#7654 Dependent node onChangeProjectCode error * fix apache#7654 Dependent node onChangeProjectCode error * fix apache#7654 Dependent node onChangeProjectCode error * update ut
caishunfeng
pushed a commit
that referenced
this pull request
Dec 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #7654 check the project permission.