Skip to content

[Fix-7345] Support the whole operations for the task group and the task group queue. #7678

Merged
caishunfeng merged 17 commits intoapache:devfrom
calvinjiang:f-task-group-ui
Dec 29, 2021
Merged

[Fix-7345] Support the whole operations for the task group and the task group queue. #7678
caishunfeng merged 17 commits intoapache:devfrom
calvinjiang:f-task-group-ui

Conversation

@calvinjiang
Copy link
Contributor

Purpose of the pull request

This PR will close #7345.

Brief change log

Verify this pull request

This change added tests and can be verified as follows:

  • Manually verified the change by testing locally.
    The page of managing the task group:
    image

image

The page of managing the task group queue:
image

Add two options in the form of task node:
image

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2021

Codecov Report

Merging #7678 (70817c6) into dev (0a7610d) will decrease coverage by 0.14%.
The diff coverage is 18.18%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #7678      +/-   ##
============================================
- Coverage     41.26%   41.11%   -0.15%     
+ Complexity     3675     3663      -12     
============================================
  Files           641      641              
  Lines         26555    26574      +19     
  Branches       2972     2975       +3     
============================================
- Hits          10958    10927      -31     
- Misses        14565    14616      +51     
+ Partials       1032     1031       -1     
Impacted Files Coverage Δ
...he/dolphinscheduler/dao/entity/TaskDefinition.java 65.48% <ø> (+1.76%) ⬆️
.../apache/dolphinscheduler/dao/entity/TaskGroup.java 78.26% <ø> (ø)
...heduler/api/service/impl/TaskGroupServiceImpl.java 59.09% <18.18%> (-4.91%) ⬇️
...he/dolphinscheduler/common/enums/SqoopJobType.java 0.00% <0.00%> (-88.89%) ⬇️
...er/master/processor/queue/TaskResponseService.java 50.00% <0.00%> (-18.19%) ⬇️
...olphinscheduler/rpc/remote/NettyServerHandler.java 69.04% <0.00%> (-7.15%) ⬇️
...rver/master/processor/queue/TaskResponseEvent.java 93.54% <0.00%> (-6.46%) ⬇️
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...org/apache/dolphinscheduler/remote/utils/Host.java 37.77% <0.00%> (-2.23%) ⬇️
...lphinscheduler/rpc/client/ConsumerInterceptor.java 89.13% <0.00%> (-2.18%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a7610d...70817c6. Read the comment docs.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

47.1% 47.1% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng
Copy link
Contributor

@calvinjiang thanks for your contribution.
It seems that sonarcloud have some bug check, please take a check.

PTAL @songjianet @wangxj3 @lenboo

Copy link
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng merged commit 5ab0135 into apache:dev Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][UI] The page of task group

4 participants