[Feature-6151][Dependent Node UI] dependent node loaded multiple times#7704
Closed
SbloodyS wants to merge 3 commits into
Closed
[Feature-6151][Dependent Node UI] dependent node loaded multiple times#7704SbloodyS wants to merge 3 commits into
SbloodyS wants to merge 3 commits into
Conversation
added 3 commits
December 29, 2021 15:19
Codecov Report
@@ Coverage Diff @@
## dev #7704 +/- ##
============================================
+ Coverage 41.08% 41.16% +0.07%
- Complexity 3674 3680 +6
============================================
Files 642 642
Lines 26659 26659
Branches 2992 2992
============================================
+ Hits 10953 10973 +20
+ Misses 14659 14638 -21
- Partials 1047 1048 +1
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
wangyizhi1
reviewed
Dec 29, 2021
| label: v.processDefinition.name | ||
| } | ||
| let definitionCacheList = JSON.parse(sessionStorage.getItem(projectCodePrefix + code)) | ||
| if (definitionCacheList) { |
Member
There was a problem hiding this comment.
Maybe it’s better to use component state to cache project definition list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #6151
Brief change log
add cache for getProcessByProjectCode