Skip to content

fixbug: varPool value is error#7724

Merged
zhuangchong merged 8 commits into
apache:devfrom
Ivan0626:dev
Feb 23, 2022
Merged

fixbug: varPool value is error#7724
zhuangchong merged 8 commits into
apache:devfrom
Ivan0626:dev

Conversation

@Ivan0626
Copy link
Copy Markdown
Contributor

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 30, 2021

Codecov Report

Merging #7724 (b627b6a) into dev (922283e) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #7724      +/-   ##
============================================
+ Coverage     45.38%   45.41%   +0.02%     
- Complexity     4031     4032       +1     
============================================
  Files           686      686              
  Lines         26725    26725              
  Branches       2870     2870              
============================================
+ Hits          12130    12138       +8     
+ Misses        13451    13441      -10     
- Partials       1144     1146       +2     
Impacted Files Coverage Δ
...pache/dolphinscheduler/spi/task/TaskConstants.java 0.00% <ø> (ø)
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 55.35% <0.00%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 922283e...b627b6a. Read the comment docs.

@zhuangchong
Copy link
Copy Markdown
Contributor

Please create an issue first and associate the PR to the issue.

@Ivan0626
Copy link
Copy Markdown
Contributor Author

Please create an issue first and associate the PR to the issue.

#7746 (comment)

Copy link
Copy Markdown
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check whether there are spaces. In fact, the best way to get data in this part is to use regular.

@Ivan0626
Copy link
Copy Markdown
Contributor Author

I improve this PR by regular, Please review this commit

zhuangchong
zhuangchong previously approved these changes Jan 12, 2022
Copy link
Copy Markdown
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zhuangchong zhuangchong merged commit 60ddede into apache:dev Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants