Skip to content

[Feature][UI-Next]: fix layout's problem#7742

Merged
wangyizhi1 merged 1 commit intoapache:devfrom
labbomb:labbomb
Dec 30, 2021
Merged

[Feature][UI-Next]: fix layout's problem#7742
wangyizhi1 merged 1 commit intoapache:devfrom
labbomb:labbomb

Conversation

@labbomb
Copy link
Member

@labbomb labbomb commented Dec 30, 2021

Purpose of the pull request

close #7673

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Copy link
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #7742 (c67152d) into dev (52a7439) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #7742      +/-   ##
============================================
- Coverage     41.03%   40.98%   -0.05%     
+ Complexity     3672     3668       -4     
============================================
  Files           641      641              
  Lines         26659    26659              
  Branches       2995     2995              
============================================
- Hits          10939    10926      -13     
- Misses        14673    14684      +11     
- Partials       1047     1049       +2     
Impacted Files Coverage Δ
...er/master/processor/queue/TaskResponseService.java 50.00% <0.00%> (-18.19%) ⬇️
...rver/master/processor/queue/TaskResponseEvent.java 93.54% <0.00%> (-6.46%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (ø)
...he/dolphinscheduler/common/enums/SqoopJobType.java 88.88% <0.00%> (+88.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52a7439...c67152d. Read the comment docs.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@wangyizhi1 wangyizhi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangyizhi1 wangyizhi1 merged commit b2e6b69 into apache:dev Dec 30, 2021
@labbomb labbomb deleted the labbomb branch January 4, 2022 01:26
@zhongjiajie zhongjiajie added feature new feature UI ui and front end related labels Jan 13, 2022
@mergeable mergeable bot removed feature new feature UI ui and front end related labels Jan 13, 2022
@zhongjiajie zhongjiajie added feature new feature UI ui and front end related labels Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature new feature UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][UI-Next]Improve layout modules

5 participants