Skip to content

[Feature-7769][API] Add batch start process api#7771

Merged
zhongjiajie merged 14 commits into
apache:devfrom
SbloodyS:feature_7769
Jan 7, 2022
Merged

[Feature-7769][API] Add batch start process api#7771
zhongjiajie merged 14 commits into
apache:devfrom
SbloodyS:feature_7769

Conversation

@SbloodyS
Copy link
Copy Markdown
Member

@SbloodyS SbloodyS commented Jan 3, 2022

Purpose of the pull request

This pr will close #7769

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 3, 2022

Codecov Report

❌ Patch coverage is 5.26316% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.99%. Comparing base (46c39cd) to head (118a839).
⚠️ Report is 3201 commits behind head on dev.

Files with missing lines Patch % Lines
...inscheduler/api/controller/ExecutorController.java 0.00% 18 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7771      +/-   ##
============================================
- Coverage     41.03%   40.99%   -0.04%     
+ Complexity     3696     3693       -3     
============================================
  Files           637      637              
  Lines         27025    27044      +19     
  Branches       3063     3067       +4     
============================================
- Hits          11090    11087       -3     
- Misses        14867    14890      +23     
+ Partials       1068     1067       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SbloodyS
Copy link
Copy Markdown
Member Author

SbloodyS commented Jan 5, 2022

@zhongjiajie RequestParam timeout can not set int as defaultValue.So I kept it as it was.Please review again.thx.

Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add NIT, others LGTM

}

/**
* batch execute process instance
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, please rebase to dev branch, we fix flaky test in our CI

@zhongjiajie
Copy link
Copy Markdown
Member

We still have discuss in #7771 (comment)

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

3.4% 3.4% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongjiajie zhongjiajie merged commit f254124 into apache:dev Jan 7, 2022
@zhongjiajie
Copy link
Copy Markdown
Member

Thanks

@SbloodyS SbloodyS deleted the feature_7769 branch January 7, 2022 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][API] Add batch start process api

4 participants