Skip to content

[Feature][workflow list edit] add task save and binds workflow#7772

Merged
wangyizhi1 merged 1 commit into
apache:devfrom
brave-lee:dev-cc
Jan 4, 2022
Merged

[Feature][workflow list edit] add task save and binds workflow#7772
wangyizhi1 merged 1 commit into
apache:devfrom
brave-lee:dev-cc

Conversation

@brave-lee
Copy link
Copy Markdown
Contributor

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #7772 (6e6aa23) into dev (4d16c24) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #7772      +/-   ##
============================================
- Coverage     40.88%   40.77%   -0.12%     
+ Complexity     3669     3666       -3     
============================================
  Files           642      642              
  Lines         26730    26786      +56     
  Branches       3004     3014      +10     
============================================
- Hits          10929    10921       -8     
- Misses        14750    14812      +62     
- Partials       1051     1053       +2     
Impacted Files Coverage Δ
...duler/api/controller/TaskDefinitionController.java 3.44% <0.00%> (-0.26%) ⬇️
...er/api/service/impl/TaskDefinitionServiceImpl.java 26.13% <0.00%> (-4.74%) ⬇️
...he/dolphinscheduler/common/enums/SqoopJobType.java 0.00% <0.00%> (-88.89%) ⬇️
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (-2.00%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 52.81% <0.00%> (+0.70%) ⬆️
...org/apache/dolphinscheduler/remote/utils/Host.java 40.00% <0.00%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d16c24...6e6aa23. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 3, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Member

@wangyizhi1 wangyizhi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants