[Bug-7788][MasterServer] fix submit duplicate tasks sometimes when retry#7808
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.0.2-release #7808 +/- ##
================================================
Coverage ? 31.33%
Complexity ? 1557
================================================
Files ? 433
Lines ? 14802
Branches ? 1483
================================================
Hits ? 4638
Misses ? 9705
Partials ? 459 Continue to review full report at Codecov.
|
zhongjiajie
reviewed
Jan 6, 2022
| logger.warn("task was found in ready submit queue, task code:{}", taskInstance.getTaskCode()); | ||
| return; | ||
| } | ||
| logger.info("add task to stand by list, task name: {}, task id:{}, task code:{}", |
Member
There was a problem hiding this comment.
Suggested change
| logger.info("add task to stand by list, task name: {}, task id:{}, task code:{}", | |
| logger.info("add task to stand by list, task name:{}, task id:{}, task code:{}", |
lenboo
reviewed
Jan 6, 2022
| Integer taskInstanceId = entry.getKey(); | ||
| if (activeTaskProcessorMaps.containsKey(taskInstanceId)) { | ||
| TaskInstance latestTaskInstance = processService.findTaskInstanceById(taskInstanceId); | ||
| if (latestTaskInstance != null && !latestTaskInstance.getState().typeIsFailure()) { |
Contributor
There was a problem hiding this comment.
Is it necessary to query task instance from db?
Contributor
Author
There was a problem hiding this comment.
Is it necessary to query task instance from db?
Yes, because the task instance in memory was not up to date.
|
SonarCloud Quality Gate failed.
|
caishunfeng
added a commit
to caishunfeng/dolphinscheduler
that referenced
this pull request
Jan 7, 2022
…try (apache#7808) * [Bug-7788] fix submit duplicate tasks sometimes when retry * add exist check when add task to standby list * update * put queue contain judge first Co-authored-by: caishunfeng <534328519@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr close #7788
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows: