Skip to content

[Feature][UI Next]Fixed menu sidebar display issues#7872

Merged
wangyizhi1 merged 1 commit into
apache:devfrom
labbomb:labbomb
Jan 7, 2022
Merged

[Feature][UI Next]Fixed menu sidebar display issues#7872
wangyizhi1 merged 1 commit into
apache:devfrom
labbomb:labbomb

Conversation

@labbomb
Copy link
Copy Markdown
Member

@labbomb labbomb commented Jan 7, 2022

Purpose of the pull request

close #7674

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Copy link
Copy Markdown
Member

@wangyizhi1 wangyizhi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #7872 (acc6c37) into dev (d014a11) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #7872      +/-   ##
============================================
- Coverage     41.06%   40.99%   -0.08%     
+ Complexity     3699     3693       -6     
============================================
  Files           637      637              
  Lines         27025    27044      +19     
  Branches       3063     3067       +4     
============================================
- Hits          11099    11087      -12     
- Misses        14856    14890      +34     
+ Partials       1070     1067       -3     
Impacted Files Coverage Δ
...he/dolphinscheduler/common/enums/SqoopJobType.java 0.00% <0.00%> (-88.89%) ⬇️
...inscheduler/api/controller/ExecutorController.java 10.00% <0.00%> (-15.00%) ⬇️
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...org/apache/dolphinscheduler/remote/utils/Host.java 37.77% <0.00%> (-2.23%) ⬇️
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (-2.00%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 52.11% <0.00%> (-1.41%) ⬇️
.../org/apache/dolphinscheduler/api/enums/Status.java 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d014a11...acc6c37. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wangyizhi1 wangyizhi1 merged commit f3f1f40 into apache:dev Jan 7, 2022
@labbomb labbomb deleted the labbomb branch January 7, 2022 07:29
@zhongjiajie zhongjiajie added feature new feature UI ui and front end related labels Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature new feature UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants