Skip to content

[2.0.3][dolphinscheduler-server] process instance is always running #7914

Merged
lenboo merged 10 commits into
apache:2.0.3-preparefrom
zwZjut:2.0.2-release#7698
Jan 10, 2022
Merged

[2.0.3][dolphinscheduler-server] process instance is always running #7914
lenboo merged 10 commits into
apache:2.0.3-preparefrom
zwZjut:2.0.2-release#7698

Conversation

@zwZjut
Copy link
Copy Markdown
Contributor

@zwZjut zwZjut commented Jan 10, 2022

Purpose of the pull request

#7700
#7698

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@zwZjut zwZjut changed the title #7700 #7698 [dolphinscheduler-server] process instance is always running Jan 10, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 10, 2022

Codecov Report

❗ No coverage uploaded for pull request base (2.0.3-prepare@6aaecdb). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head cac0693 differs from pull request most recent head ea9639e. Consider uploading reports for the commit ea9639e to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##             2.0.3-prepare    #7914   +/-   ##
================================================
  Coverage                 ?   31.15%           
  Complexity               ?     1556           
================================================
  Files                    ?      435           
  Lines                    ?    14956           
  Branches                 ?     1500           
================================================
  Hits                     ?     4659           
  Misses                   ?     9836           
  Partials                 ?      461           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aaecdb...ea9639e. Read the comment docs.

Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng added this to the 2.0.3-release milestone Jan 10, 2022
@sonarqubecloud
Copy link
Copy Markdown

@lenboo
Copy link
Copy Markdown
Contributor

lenboo commented Jan 10, 2022

@zwZjut @caishunfeng Well done! At the same time , i think we can add some descriptions what these changes would affect.
Eg :

  1. The killing process of workflow.
  2. ...

Copy link
Copy Markdown
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lenboo lenboo merged commit 8dc529d into apache:2.0.3-prepare Jan 10, 2022
@caishunfeng
Copy link
Copy Markdown
Contributor

caishunfeng commented Jan 13, 2022

Mainly stability optimization:

  • Fixed that in some cases concurrent consumption of events resulted in no consumption, resulting in the workflow instance running all the time;
  • Optimization of kill logic;
  • Workflow instance start exception retry;

@caishunfeng caishunfeng changed the title [dolphinscheduler-server] process instance is always running [2.0.3][dolphinscheduler-server] process instance is always running Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants