Skip to content

[do-not-merge][ci] Temporary remove E2E in required context#7920

Closed
zhongjiajie wants to merge 4 commits into
apache:devfrom
zhongjiajie:ci-tmp-not-request-e2e
Closed

[do-not-merge][ci] Temporary remove E2E in required context#7920
zhongjiajie wants to merge 4 commits into
apache:devfrom
zhongjiajie:ci-tmp-not-request-e2e

Conversation

@zhongjiajie
Copy link
Copy Markdown
Member

It seem that our clean tenant have some problem,
this flaky test make some unrelated PR can not
be merged for now. I try to fix in 079adc9 but
failed, So I temporary remove required E2E context

It seem that our clean tenant have some problem,
this flaky test make some unrelated PR can not
be merged for now. I try to fix in 079adc9 but
failed, So I temporary remove required E2E context
caishunfeng
caishunfeng previously approved these changes Jan 10, 2022
Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #7920 (74b2f03) into dev (7bc1591) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head 74b2f03 differs from pull request most recent head 4adc809. Consider uploading reports for the commit 4adc809 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #7920      +/-   ##
============================================
- Coverage     41.07%   40.98%   -0.09%     
+ Complexity     3702     3693       -9     
============================================
  Files           637      637              
  Lines         27058    27058              
  Branches       3073     3073              
============================================
- Hits          11113    11089      -24     
- Misses        14873    14899      +26     
+ Partials       1072     1070       -2     
Impacted Files Coverage Δ
...er/master/processor/queue/TaskResponseService.java 50.00% <0.00%> (-18.19%) ⬇️
...rver/master/processor/queue/TaskResponseEvent.java 93.54% <0.00%> (-6.46%) ⬇️
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...org/apache/dolphinscheduler/remote/utils/Host.java 37.77% <0.00%> (-2.23%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 52.11% <0.00%> (-1.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bc1591...4adc809. Read the comment docs.

It seem that our clean tenant have some problem,
this flaky test make some unrelated PR can not
be merged for now. I try to fix in 079adc9 but
failed, So I temporary remove clean up code in
e2e
@zhongjiajie zhongjiajie self-assigned this Jan 10, 2022
@zhongjiajie zhongjiajie changed the title [ci] Temporary remove E2E in required context [do-not-merge][ci] Temporary remove E2E in required context Jan 10, 2022
@zhongjiajie
Copy link
Copy Markdown
Member Author

Do not merge see whether #7921 could fix our e2e or not

@zhongjiajie zhongjiajie removed the request for review from caishunfeng January 10, 2022 09:08
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zhongjiajie zhongjiajie marked this pull request as draft January 11, 2022 02:44
@zhongjiajie zhongjiajie deleted the ci-tmp-not-request-e2e branch March 22, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants