Skip to content

[Feature][UI Next] Add file manage#7943

Merged
zhongjiajie merged 12 commits intoapache:devfrom
devosend:feat/file-manage
Jan 13, 2022
Merged

[Feature][UI Next] Add file manage#7943
zhongjiajie merged 12 commits intoapache:devfrom
devosend:feat/file-manage

Conversation

@devosend
Copy link
Copy Markdown
Contributor

@devosend devosend commented Jan 11, 2022

Purpose of the pull request

#7785

Brief change log

  • File Manage

display

  • file list
    image

  • create folder
    image

  • create file
    image

  • edit file
    image

Copy link
Copy Markdown
Member

@labbomb labbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@songjianet Please review it

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 13, 2022

Codecov Report

Merging #7943 (bcf2766) into dev (23068e9) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #7943      +/-   ##
============================================
- Coverage     41.24%   41.21%   -0.03%     
+ Complexity     3719     3716       -3     
============================================
  Files           637      637              
  Lines         27128    27128              
  Branches       3081     3081              
============================================
- Hits          11188    11180       -8     
- Misses        14862    14873      +11     
+ Partials       1078     1075       -3     
Impacted Files Coverage Δ
...he/dolphinscheduler/common/enums/SqoopJobType.java 0.00% <0.00%> (-88.89%) ⬇️
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (-2.00%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 53.52% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23068e9...bcf2766. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

0.0% 0.0% Coverage
4.5% 4.5% Duplication

@devosend
Copy link
Copy Markdown
Contributor Author

PTAL @songjianet

Copy link
Copy Markdown
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@labbomb labbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @devosend

@zhongjiajie zhongjiajie merged commit 97f84ae into apache:dev Jan 13, 2022
@zhongjiajie zhongjiajie added feature new feature UI ui and front end related labels Jan 13, 2022
@mergeable mergeable bot removed feature new feature UI ui and front end related labels Jan 13, 2022
@zhongjiajie zhongjiajie added feature new feature UI ui and front end related labels Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature new feature UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants