Skip to content

[Fix-7513] Fix identical numbers and add positive integer judgment#8032

Merged
caishunfeng merged 22 commits intoapache:devfrom
SbloodyS:bug_7513
Jan 14, 2022
Merged

[Fix-7513] Fix identical numbers and add positive integer judgment#8032
caishunfeng merged 22 commits intoapache:devfrom
SbloodyS:bug_7513

Conversation

@SbloodyS
Copy link
Copy Markdown
Member

Purpose of the pull request

This pr will close #7513

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 14, 2022

Codecov Report

Merging #8032 (db19c93) into dev (08e303f) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #8032      +/-   ##
============================================
- Coverage     41.21%   41.18%   -0.03%     
+ Complexity     3716     3714       -2     
============================================
  Files           637      637              
  Lines         27129    27129              
  Branches       3083     3083              
============================================
- Hits          11181    11174       -7     
- Misses        14867    14877      +10     
+ Partials       1081     1078       -3     
Impacted Files Coverage Δ
...he/dolphinscheduler/common/enums/SqoopJobType.java 0.00% <0.00%> (-88.89%) ⬇️
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (ø)
...er/master/dispatch/host/assign/RandomSelector.java 83.33% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08e303f...db19c93. Read the comment docs.

@caishunfeng
Copy link
Copy Markdown
Contributor

PTAL @songjianet

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Copy Markdown
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@caishunfeng caishunfeng merged commit e45e78d into apache:dev Jan 14, 2022
@SbloodyS SbloodyS deleted the bug_7513 branch January 14, 2022 08:02
SbloodyS added a commit to SbloodyS/dolphinscheduler that referenced this pull request Jan 14, 2022
…pache#8032)

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* test

* test

* test

* test

* test

* chinese change
@SbloodyS SbloodyS mentioned this pull request Jan 14, 2022
caishunfeng pushed a commit that referenced this pull request Jan 14, 2022
* resolve conflict

* [Fix-7513] Fix identical numbers and add positive integer judgment (#8032)

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* test

* test

* test

* test

* test

* chinese change

Co-authored-by: Assert <42203474+shangeyao@users.noreply.github.com>
yimaixinchen pushed a commit to yimaixinchen/dolphinscheduler that referenced this pull request Jan 19, 2022
…pache#8032)

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* fix bug_7513

* test

* test

* test

* test

* test

* chinese change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][UI] max retry time and max retry delay dropdown box can be edited

4 participants