Skip to content

[Feature][UI Next]Fixed Dart-Sass installation error#8071

Merged
caishunfeng merged 1 commit intoapache:devfrom
labbomb:labbomb
Jan 16, 2022
Merged

[Feature][UI Next]Fixed Dart-Sass installation error#8071
caishunfeng merged 1 commit intoapache:devfrom
labbomb:labbomb

Conversation

@labbomb
Copy link
Copy Markdown
Member

@labbomb labbomb commented Jan 16, 2022

Purpose of the pull request

Please refer to the issue #8070 .

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Copy link
Copy Markdown
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #8071 (06c2fbb) into dev (ec7898d) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #8071      +/-   ##
============================================
- Coverage     41.42%   41.32%   -0.11%     
+ Complexity     3726     3716      -10     
============================================
  Files           637      637              
  Lines         27114    27114              
  Branches       3075     3075              
============================================
- Hits          11232    11204      -28     
- Misses        14802    14836      +34     
+ Partials       1080     1074       -6     
Impacted Files Coverage Δ
...he/dolphinscheduler/common/enums/SqoopJobType.java 0.00% <0.00%> (-88.89%) ⬇️
...er/master/processor/queue/TaskResponseService.java 50.00% <0.00%> (-18.19%) ⬇️
...rver/master/processor/queue/TaskResponseEvent.java 93.54% <0.00%> (-6.46%) ⬇️
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...org/apache/dolphinscheduler/remote/utils/Host.java 37.77% <0.00%> (-2.23%) ⬇️
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (ø)
...e/dolphinscheduler/remote/NettyRemotingClient.java 52.11% <0.00%> (+1.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec7898d...06c2fbb. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@caishunfeng caishunfeng merged commit 957c8ea into apache:dev Jan 16, 2022
@labbomb labbomb deleted the labbomb branch January 17, 2022 10:19
yimaixinchen pushed a commit to yimaixinchen/dolphinscheduler that referenced this pull request Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants