Skip to content

[Feature][UI Next] Add monaco editor to form#8241

Merged
kezhenxu94 merged 1 commit into
apache:devfrom
Amy0104:form-editor
Jan 28, 2022
Merged

[Feature][UI Next] Add monaco editor to form#8241
kezhenxu94 merged 1 commit into
apache:devfrom
Amy0104:form-editor

Conversation

@Amy0104
Copy link
Copy Markdown
Member

@Amy0104 Amy0104 commented Jan 28, 2022

Purpose of the pull request

Add monaco editor widget to form.

Brief change log

  • Form Component - Monaco Editor

Releated issues

#7928

Copy link
Copy Markdown
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@labbomb labbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kezhenxu94 kezhenxu94 added the UI ui and front end related label Jan 28, 2022
@devosend
Copy link
Copy Markdown
Contributor

LGTM

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #8241 (d777166) into dev (a778146) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev    #8241   +/-   ##
=========================================
  Coverage     44.94%   44.94%           
  Complexity     3950     3950           
=========================================
  Files           672      672           
  Lines         26182    26182           
  Branches       2825     2825           
=========================================
  Hits          11768    11768           
  Misses        13304    13304           
  Partials       1110     1110           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a778146...d777166. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kezhenxu94 kezhenxu94 merged commit 832f735 into apache:dev Jan 28, 2022
@Amy0104 Amy0104 deleted the form-editor branch March 10, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants